Errors, Warnings, and Issues WARNING #2077

Size: px

Start display at page:

Download "Errors, Warnings, and Issues WARNING #2077"

Samuel Clifford Riley
6 years ago
Views:

1 WARNING #2077 Change the default 0 index in the Rows property with the correct one. Description When upgrading an ADO Recordset object to native ADO.Net, the VBUC converts all the Recordset objects to System.Data.DataSet, however there are major differences between these two classes. Cursors in ADO control record navigation in a Recordset; this way you are always pointing to a current row in the Recordset. This concept is not available in a DataSet object, which contains a collection of tables, and each table contains a collection of Rows and Columns, among other data. Since there is no current row concept in a DataSet object, when there are uses of a Recordset s current row, the VBUC then converts them to be the first Row of the first table in the DataSet, and the EWI is generated. Note: In ADO, most of the time Recordset objects contain a single table retrieved from the Database. Therefore, the generated DataSets will only have one table in their Tables collections. Recommendations Review case by case to see if the first record of the DataTable object is actually the one intended to be used. If not, a change of logic might be required to achieve the functional equivalence between the original application and the upgraded one. Also, turn on the ADODB-RDO feature in the VBUC (when available) to generate "Foreach" structures in places that match common recordset navigation patterns. Sample VB6 Dim cn As Connection Dim rs1 As Recordset Dim cmd As Command Set cmd = New Command.ActiveConnection = cn.commandtype = adcmdtext Set rs1 = cmd.execute If rs1.eof = False Then If rs1!name <> "" Then Debug.Print rs1!name If rs1! <> "" Then Debug.Print rs1! rs1.close Set cmd = New Command.ActiveConnection = cn.commandtype = adcmdtext

2 Set rs1 = cmd.execute If rs1.eof = False Then For i = 1 To rs1.recordcount If rs1!name <> "" Then Debug.Print rs1!name If rs1! <> "" Then Debug.Print rs1! rs1.move rs1.close Target VB.NET Dim cn As SqlConnection Dim cmd As New SqlCommand Dim adap As SqlDataAdapter = New SqlDataAdapter(cmd.CommandText, cmd.connection) Dim rs1 As DataSet = New DataSet("dsl") adap.fill(rs1) If Not (rs1.tables(0).rows.count = 0) Then 'UPGRADE_WARNING: (2077) Change the default 0 index in the Rows property 'with the correct one. More Information: 'UPGRADE_WARNING: (2077) Change the default 0 index in the Rows property 'with the correct one. More Information: cmd = New SqlCommand() Dim adap_2 As SqlDataAdapter = New SqlDataAdapter(cmd.CommandText, cmd.connection) rs1 = New DataSet("dsl") adap_2.fill(rs1) If Not (rs1.tables(0).rows.count = 0) Then For i AsInteger = 1 To rs1.tables(0).rows.count 'UPGRADE_WARNING: (2077) Change the default 0 index in the Rows property with 'the correct one. 'UPGRADE_WARNING: (2077) Change the default 0 index in the Rows property with 'the correct one.

3 'UPGRADE_ISSUE: (2064) ADODB.Recordset method rs1.move was not upgraded UpgradeStubs.ADODB_Recordset.Move(rs1) Expected VB.NET Dim cn As SqlConnection Dim cmd AsNew SqlCommand Dim adap As SqlDataAdapter = New SqlDataAdapter(cmd.CommandText, cmd.connection) Dim rs1 As DataSet = New DataSet("dsl") adap.fill(rs1) IfNot (rs1.tables(0).rows.count = 0) Then 'The Rows(0) is correct here!! EndIf cmd = New SqlCommand() EndWith Dim adap_2 As SqlDataAdapter = New SqlDataAdapter(cmd.CommandText, cmd.connection) rs1 = New DataSet("dsl") adap_2.fill(rs1) IfNot (rs1.tables(0).rows.count = 0) Then 'In this case the for loop handles the row iteration, replace the Rows(0) by the for s loop variable For i AsInteger = 1 To rs1.tables(0).rows.count Debug.WriteLine(rs1.Tables(0).Rows(i)("Name")) Debug.WriteLine(rs1.Tables(0).Rows(i)(" ")) Target C# SqlConnection cn = null; //Example one: only the first row is being used. SqlCommand cmd = newsqlcommand(); cmd; cmd;

4 cmd; SqlDataAdapter adap = new SqlDataAdapter(cmd.CommandText, cmd.connection); DataSet rs1 = new DataSet("dsl"); adap.fill(rs1); //UPGRADE_WARNING: (2077) Change the default 0 index in the Rows property // with the correct one. //UPGRADE_WARNING: (2077) Change the default 0 index in the Rows property // with the correct one. //Example two: the recordset is being iterated cmd = new SqlCommand(); cmd; cmd; cmd; SqlDataAdapter adap_2 = new SqlDataAdapter(cmd.CommandText, cmd.connection); rs1 = new DataSet("dsl"); adap_2.fill(rs1); int tempforvar = rs1.tables[0].rows.count; for (int i = 1; i <= tempforvar; i++) //UPGRADE_WARNING: (2077) Change the default 0 index in the Rows //property with the correct one. //UPGRADE_WARNING: (2077) Change the default 0 index in the Rows //property with the correct one. //UPGRADE_ISSUE: (2064) ADODB.Recordset method rs1. //Move was not upgraded. UpgradeStubs.ADODB_Recordset.Move(rs1); Expected C# SqlConnection cn = null; //Example one: only the first row is being used. SqlCommand cmd = new SqlCommand(); cmd; cmd; cmd; SqlDataAdapter adap = new SqlDataAdapter(cmd.CommandText, cmd.connection); DataSet rs1 = new DataSet("dsl"); adap.fill(rs1);

5 //The Rows[0] is correct here. //Example two: the recordset is being iterated cmd = new SqlCommand(); cmd; cmd; cmd; SqlDataAdapter adap_2 = new SqlDataAdapter(cmd.CommandText, cmd.connection); rs1 = new DataSet("dsl"); adap_2.fill(rs1); int tempforvar = rs1.tables[0].rows.count; //In this case the for loop handles the row iteration, replace the Rows[0] //by the for loop variable for (int i = 0; i < tempforvar; i++) Debug.WriteLine(rs1.Tables[0].Rows[i]["Name"]); Debug.WriteLine(rs1.Tables[0].Rows[i][" "]);

A201 Object Oriented Programming with Visual Basic.Net

A201 Object Oriented Programming with Visual Basic.Net By: Dr. Hossein Computer Science and Informatics IU South Bend 1 What do we need to learn in order to write computer programs? Fundamental programming