Afsin Ustundag, Ray Group International

Transcription

1 Afsin Ustundag, Ray Group International 1

2 Background Epic EpicCare/Orders developer for 5 years during legacy to Epic desktop transition and first Inpatient implementation Epic Application Level Mumps Code No direct global access except temporary globals No indirection, no assumed variables No $TEXT, no naked globals Clear boundaries between different applications End Result Developers are ready to develop in M after 15 days of training Minimal application level code change for Kaiser Permanente 2

3 Project Objectives Focus on application layer modules Developing and documenting interfaces between these application modules and other modules in the codebase Decompose codebase into modular components and develop open, standardized interfaces that make component function accessible via modern programming practices to support three-tier architecture model Refactoring entire codebase is monumental and outside project s scope project will focus on refactoring one module to start and establish methodology for future module refactoring 3

4 Project Deliverables Identify application layer modules, common services, and interfaces required Refactored source codes One or more packages of our choice No new functionality added Mainly reorganization of existing code to make more modular and accessible Making the code compliant with OSEHRA guidelines Mumps only 4

5 Project Deliverables Dependency Tool Identify dependencies Identify code quality Refactoring Testing MUnit Tests Automated Functional Tests Manual Test Plans 5

6 Technical Approach First step: Identify module-to-module and module-to-data dependencies within the codebase XINDEX and other enhanced utilities help generate dependency database Determine initial module to be refactored based on dependencies; future modules will be based on lessons learned from the first selected Second step: Organize refactored module(s) to support a three-tier architecture model User interface layer, business layer, and data storage layer Develop well-defined API between these layers Use Agile incremental development methodology (Scrum; 4 week Sprint cycles) Uphold best practices of open source software and community involvement 6

7 Dependency Tool - Delivered XINDEX variant Entry Point (tag) based instead of routine based Formal parameters available Input and outputs are available Fileman call based dependencies are available Automated Package to Package Interfaces Routine to routine Interfaces are specified as tags in routines Formal parameters, inputs, and outputs Code quality Globals (top level) Indirection and Xecute statements Read and write statements Not newed variables 7

8 Dependency Tool Beta version is submitted as OSEHRA Technical Journal VistA M Routine Analyzer code.osehra.org/journal/browse/publication/9 Work for certification readiness is continuing Java version for testing purposes 8

9 Refactoring - Package Choice Problem List is chosen as the first package to refactor Does not have too many dependencies Does not have too few dependencies Is a clinical package Has both roll-and-scroll interface and GUI (CPRS) 9

10 Problem List - Current RPC tags for CPRS form an API Some code sharing with roll-and-scroll interface Commonalities are not clearly identified in code A number of unnecessary assumed variables Code repetition from copy/pasted code Direct global access Missing functionality from roll-and-scroll interface 10

11 Problem List Refactored An improved API with error checking and minimal number of assumed variables (DUZ, DT, U) Roll-and-scroll interface and RPC calls share the new API; commonalities refactored Most global access is now through Fileman Other packages use Problem List through this API Code cleaning MUnit tests for the API and old RPC calls Automated/Manual tests for roll-and-scroll interface and CPRS 11

12 Problem List Refactored Submitted for certification as OSEHRA Technical Journal Problem List Refactoring code.osehra.org/journal/browse/publication/13 Code is available on github.com github.com/kthlnkeating/vistafoia More documentation on API document, dependency notes 12

13 Scheduling - Refactoring Next package being worked on There is an established API for reading appointment information We found no API for making appointments Concentrating on Appointment Management menu option First step: refactoring business logic into a new API without UI 13

14 Testing MUnit Tests A suite of MUnit tests is developed for current RPC entry points and submitted to OSEHRA A suite of MUnit tests is developed for the new API and submitted together with refactored Problem List code Automated Functional Testing Manual GUI Testing Test plans are available on 14

15 Other Activities Fileman refactoring investigation Possible Fileman improvements are being investigated in the context of package dependency decoupling and/or package replacement No code change is expected Eclipse plug-ins for automated refactoring New all local variables Replace old style tag; go to based loops Replace naked globals 15

16 Paul Bradley, Ray Group International Paul Bradley, Ray Group International 16

17 Objectives Automate the process by which refactored/open Source EHR code is tested via roll-and-scroll or CPRS interfaces Use open source tools Must run on Windows and Linux Should not require extensive Mumps programming skills Flexible and extensible Can be used to test any package Can be used for Integration Testing Can be used for System Testing Can be used for Regression Testing 17

18 Overview test harness CMAKE /CTEST Python w/pexpect VistA telnet Roll and Scroll / Command-line test harness CPRS GUI CMAKE /CTEST Sikuli Jython CPRS VistA VistA-RPC 18

19 Tools Python with Pexpect Sikuli Automate and test GUIs using images Jython Runs on Windows, Linux, MAC OS Cmake Cross-platform open source build system 19

20 Automated build and test CMAKE CTEST 1 2 # create VistA instance cmake P ImportRG.cmake # setup and populate with test data cmake P PostSetup.cmake cmake.cmake (tests).py.py (results).log.py 3 4 # execute Roll and Scroll tests ctest R RASTests # execute sikuli tests ctest R SIKTests.py.py generated (scripts).py.py (helpers).py.py (pexpect).py.py (xyz).py.py test scripts modules 20

21 Basic Code Structure rastest_main (result_dir, logging_level) # files = Glob(./tests) For xfile in tests os.system(python xfile) PLActions pl_testmain01 (result_dir) # pl_suite001.pl_test001() pl_suite001.pl_test002() pl_suite001.pl_test012() pl_test001 (result_log) # pl = PLActions(vista,..) pl.signon() pl.addcsv pl.editinactivate() pl.verplist() pl.verify() pl.rem() pl.signoff() OSEHRAhelper 21

22 Basic Code Structure (cont.) rastest_main (result_dir, logging_level) # files = Glob(./tests) For xfile in tests os.system(python xfile) pl_testmain01 (result_dir) # pl_suite001.pl_test001() pl_suite001.pl_test002() sch_testmain01 pl_test001 pl_test002 (result_log) pl_test003 # (result_log) pl_test004 # (result_log) # (result_log) # Pl_actions (result_dir) # sch_suite001.sch_test001() sch_suite001.sch_test002()... sch_test001 sch_test002 (result_log) sch_test003 # (result_log) sch_test004 # (result_log) # (result_log) # Sch_actions or_testmain01 (result_dir) # or_suite001.or_test001() or_suite001.sch_test003() or_test001 or_test002 (result_log) or_test003 # (result_log) or_test004 # (result_log) # (result_log) # Or_actions 22

23 Challenges Transactions Handling conditional responses Future plans Sikuli Coverage metrics Methods for handling conditional responses Roll-and-scroll script recorder TSTART/TROLLBACK support Code available at: 23

24 Resources / Links:

25 Questions? 25