Chamilo LMS - Feature #6015 Improve procedure to add new friends in the social network 07/03/2013 12:46 - Noa Orizales Iglesias Status: Feature implemented Start date: 07/03/2013 Priority: Normal Due date: Assignee: Yoselyn Castillo % Done: 100% Category: Social Estimated time: 0.00 hour Target version: 1.9.8 Spent time: 0.70 hour Complexity: Normal SCRUM pts - complexity:? Description Rigth now when someone looks for a frind, it has to go through one extra step to get him invited or to send him a message. I think it would be more intuitive if we could add a button below each friend profile to directly perform those actions. See the screenshot for more details. Related issues: related to Chamilo LMS - Feature # 5160: Add icons to button, links in Boots... Needs more info11/07/2012 Associated revisions Revision 7dba38bf - 29/04/2013 02:35 - Yannick Warnier Merge branch 'ycastillo-yoselyn.social' into 1.9.x - refs #6015 Revision a2c36dfa - 29/04/2013 02:37 - Yannick Warnier Merge branch '1.9.x' of github.com:chamilo/chamilo-lms into 1.9.x - refs #6015 Revision 3e4ad841-20/05/2013 21:53 - Yannick Warnier Merge pull request #53 from ycastillo/6015.new New Add friends - refs #6015 Revision 4520950e - 21/05/2013 21:58 - Yannick Warnier Merge pull request #55 from ycastillo/6015.new style changes in adding friends - refs #6015 Revision dd45b2f3-24/05/2013 04:44 - Yannick Warnier Merge ycastillo-yoselyn.6015 - refs #6015 Revision dae33f52-04/06/2013 11:40 - Julio Montoya Undo images in social buttons see #6015 21/12/2018 1/12
Revision 1eace481-04/06/2013 11:41 - Julio Montoya Merge pull request #70 from jmontoyaa/1.9.x Undo images in social buttons see #6015 Revision a0f9a677-27/08/2013 17:52 - Julio Montoya Adding font_awesome icons + adding in the search see #6015 History #1-07/03/2013 20:44 - Yannick Warnier - Category set to Social - Target version set to 1.9.6 Rejected: Making friends shouldn't be easier than it is in the real world... Just kidding :-D We know the procedure is a bit complicated. Your example is fine, but I think it would better to use icons directly, instead of literals. Please try to assign a category anytime you see that one could fit. #2-08/03/2013 12:46 - Noa Orizales Iglesias jejeje. I agree, icons would be better. My screenshot was juts to give an example. Alberto Montes can make them. Do I ask him to create them. If yes.. Can you tell me if they have to have an specific size? #3-08/03/2013 17:01 - Yannick Warnier There should be 3 "buttons" (not really "icons") in the total width of the friend block: - Add friend (optional, appear in gray if already your friend) - Send message - Chat (only available if it's your friend, otherwise gray) #4-09/03/2013 13:02 - Noa Orizales Iglesias - Status changed from New to Assigned - Assignee set to Alberto Montes Ok. Alberto, Could you please create those buttons that Yannick is requesting for the social network? Thanks. #5-12/03/2013 13:22 - Alberto Montes - File example.png added 21/12/2018 2/12
Hola!! os adjunto un preview con 2 propuestas una cómo lo había enviado Yannick los botones en fila y otro con los botones uno debajo del otro, este último me parece más amigable desde el punto de vista visual. Ya me comentan. El estilo de los botones que he utilizado es idem al botón que aparece en la parte superior de "Cambiar a vista de alumno" para así mantener la misma línea de diseño. Adjunto SVG e iconos sueltos en un zip #6-12/03/2013 13:24 - Alberto Montes - File svg_iconos.zip added svg con iconos #7-12/03/2013 13:26 - Alberto Montes - Assignee changed from Alberto Montes to Noa Orizales Iglesias - % Done changed from 0 to 40 #8-12/03/2013 13:41 - Alberto Montes - Assignee changed from Noa Orizales Iglesias to Yannick Warnier #9-29/03/2013 02:24 - Yannick Warnier - Assignee changed from Yannick Warnier to Cesar Perales #10-01/04/2013 14:35 - Emiliano Orizales Esta funcionalidad no está implementada de momento. Los botones no se han incorporado en el perfil de cada amigo, siguen los enlaces antiguos. #11-15/04/2013 13:11 - Noa Orizales Iglesias César, puedes echarle un ojo a esta tarea? La he revisado yo también y los iconos no están todavía subidos a la red social en stable.chamilo.org Si los subes, podemos revisarlo hoy mimso y confirmarte que está bien. #12-17/04/2013 09:49 - Yannick Warnier - Assignee changed from Cesar Perales to Yoselyn Castillo #13-24/04/2013 17:44 - Yoselyn Castillo - Status changed from Assigned to Needs testing - Assignee deleted (Yoselyn Castillo) commit was sent. Needs testing #14-24/04/2013 17:53 - Yoselyn Castillo - % Done changed from 40 to 80 21/12/2018 3/12
test in http://stable.chamilo.org/main/social/search.php #15-24/04/2013 18:23 - Emiliano Orizales Funciona correctamente pero pienso que los iconos son demasiado pequeños y pueden suponer una dificultad para la usabilidad #16-24/04/2013 18:29 - Noa Orizales Iglesias - Status changed from Needs testing to Assigned - Assignee set to Yoselyn Castillo #17-25/04/2013 15:14 - Yoselyn Castillo Ok, i will correct this and i will add a hint message in order to improve users understanding. #18-27/04/2013 18:55 - Yoselyn Castillo - Assignee changed from Yoselyn Castillo to Julio Montoya I have sent a pull request fixing the recommendations. Waiting in the repo #19-29/04/2013 04:44 - Yannick Warnier - Status changed from Assigned to Feature implemented - Assignee changed from Julio Montoya to Yoselyn Castillo - % Done changed from 80 to 100 Good for me. #20-30/04/2013 19:22 - Noa Orizales Iglesias Yannick, I believe the icons are still very small. #21-30/04/2013 22:26 - Yannick Warnier - Status changed from Feature implemented to Assigned - Assignee changed from Yoselyn Castillo to Noa Orizales Iglesias Please provide an ideal format. #22-02/05/2013 13:50 - Noa Orizales Iglesias - Assignee changed from Noa Orizales Iglesias to Alberto Montes Ok, Alberto, will send a proposal soon. 21/12/2018 4/12
#23-10/05/2013 11:32 - Alberto Montes - File example2.png added - File example3.png added Attachment 2 proposals with larger icons. The icons will appear in gray if disabled. example2.png example3.png This is a html for the buttons: <button class="btn btn-mini">mini button </button> If its ok, I tuning up the icons and will send to you a tranparents png. #24-14/05/2013 07:45 - Yannick Warnier - Assignee changed from Alberto Montes to Yoselyn Castillo Alberto, no te olvides de pasar la pelota cuando ya no puedes hacer nada (en este caso re-asignar a quien te pidió iconos o a quien estaba trabajando sobre la tarea y estaba esperando los iconos para avanzar). #25-14/05/2013 10:10 - Alberto Montes Sí, discúlpame que se me pasó. #26-15/05/2013 19:16 - Yoselyn Castillo - Assignee changed from Yoselyn Castillo to Alberto Montes Please upload those icons here (with the size you have attached). Your proposal looks very well #27-15/05/2013 21:33 - Yoselyn Castillo - Assignee changed from Alberto Montes to Yoselyn Castillo #28-16/05/2013 13:52 - Alberto Montes - File images.zip added Good!!, I attached the following 5 icons, any details you tell me. - mail - adduser-on - adduser-off - chat-on - char-off 21/12/2018 5/12
#29-16/05/2013 21:30 - Yoselyn Castillo I have not added a button for chat, because i kept the format of status online or offline besides user number The new pull request was sent here: https://github.com/chamilo/chamilo-lms/pull/46 Tell me what do you think? #30-20/05/2013 11:27 - Alberto Montes - File css_change.png added As I see in http://stable.chamilo.org/main/social/friends.php I propose would change the buttons a bit smaller, I say apply a class="btn btn-mini" to the buttons, I think that when we have many buttons there is not enough space, what do you think? Attached proposed css changes. #31-20/05/2013 21:52 - Yoselyn Castillo - File social.gif added Changes are sent to https://github.com/chamilo/chamilo-lms/pull/53 They are not integrated to stable.chamilo.org yet But it is following your suggestions of btn-mini, and adding a backgroud for the button. It looks like this #32-20/05/2013 21:54 - Yoselyn Castillo - File deleted (social.gif) #33-20/05/2013 21:56 - Yoselyn Castillo - File social.gif added 21/12/2018 6/12
#34-21/05/2013 10:27 - Alberto Montes Look nice, well just a add a little space between buttons and some padding of the icons, but when the changes is in stable I can adjust it. #35-21/05/2013 18:39 - Yoselyn Castillo - File new-social.gif added New styling changes were sent to https://github.com/chamilo/chamilo-lms/pull/55 It looks like this 21/12/2018 7/12
#36-21/05/2013 23:11 - Yannick Warnier - Status changed from Assigned to Needs testing - Assignee changed from Yoselyn Castillo to Noa Orizales Iglesias - % Done changed from 100 to 90 Noa, some feedback so we can close this task? #37-21/05/2013 23:28 - Noa Orizales Iglesias - Assignee changed from Noa Orizales Iglesias to Yannick Warnier Hi, it was Alberto Montes who was supervising this task, but I can confirm you that if it looks like in Yoselyn s picture, it will be ok. Much more clear for teh user now. From my point of view you can close it. #38-22/05/2013 08:35 - Yannick Warnier - Status changed from Needs testing to Feature implemented - Assignee changed from Yannick Warnier to Yoselyn Castillo - % Done changed from 90 to 100 I was asking you because you opened the task :-) OK, thanks. #39-22/05/2013 12:01 - Alberto Montes All right, but just a milimetrical tuning: the distance between the button and user image should be the same, and in the Send invitation button space between icon and text should be the same of the other button. After that you can close ;) #40-23/05/2013 21:22 - Yoselyn Castillo Done in https://github.com/chamilo/chamilo-lms/pull/59 #41-23/05/2013 21:36 - Yannick Warnier Refused for now (techie explanation on github). I think there was a copy-paste mistake there... #42-24/05/2013 02:25 - Yoselyn Castillo Yes, it is a copy-paste mistake, changes in base.css are only for new social buttons, Anyway i will send the commit again #43-04/06/2013 11:36 - Julio Montoya - File Tooltip_004.png added 21/12/2018 8/12
- Status changed from Feature implemented to Needs more info - % Done changed from 100 to 90 This does not work for me. I have this issue in FF v21 and Chrome v28 We should use as much as possible Bootstrap (that's why it was added in Chamilo) in order to avoid custom changes. In order to add icons to buttons : http://twitter.github.io/bootstrap/base-css.html#buttons (star example) There's a related task #5160 #44-04/06/2013 11:41 - Julio Montoya - File Selection_005.png added - % Done changed from 90 to 50 I'm undoing some changes so it looks like this now: 21/12/2018 9/12
https://github.com/chamilo/chamilo-lms/pull/70 #45-04/06/2013 12:23 - Noa Orizales Iglesias Does that mean we can t use icons there? It was much more intuitive with an icon that without it. #46-04/06/2013 12:40 - Julio Montoya - Assignee deleted (Yoselyn Castillo) Noa Orizales Iglesias wrote: Does that mean we can t use icons there? It was much more intuitive with an icon that without it. We can't use icon the way it was implemented here. We have to have a global solution see task #5160 that deals exactly with the problem of buttons and icons. #47-05/06/2013 02:06 - Yannick Warnier - Target version changed from 1.9.6 to 1.9.8 #48-20/07/2013 06:28 - Yannick Warnier I have no problem in including Font Awesome. Julio, is there something already in the Chamilo 1.9 code about this (font awesome inclusion)? #49-22/08/2013 15:56 - Yannick Warnier - Assignee set to Julio Montoya #50-27/08/2013 02:48 - Yannick Warnier Julio, waiting an answer from you here... #51-27/08/2013 16:51 - Julio Montoya - Status changed from Needs more info to Assigned Yannick Warnier wrote: I have no problem in including Font Awesome. Julio, is there something already in the Chamilo 1.9 code about this (font awesome inclusion)? fontawesome was added in 1.10, but not in 1.9.x I will add it and try to resolve this one. #52-27/08/2013 17:52 - Julio Montoya - File Selection_001.png added 21/12/2018 10/12
I just added the icons: #53-27/08/2013 17:52 - Julio Montoya - Status changed from Assigned to Needs testing - Assignee deleted (Julio Montoya) #54-23/12/2013 22:48 - Yannick Warnier - Assignee set to Daniel Barreto Daniel, we just need a quick review here that the functionality is working more or less without any problem. #55-24/12/2013 01:18 - Daniel Barreto - % Done changed from 50 to 60 Tested and works good, but I would prefer 2 big buttons of icon of person whit a plus symbol for add friend and and icon of letter for send message. They work I don't know if the next issues are related to the changes here, like the css. But I'll comment them. When the width is less than 1200px aprox. the user are showed whit only 2 columns leaving a big blank space on the right side. The buttons put down under the image and the images are deformed (too thin) and also leave more blank space. This occurs until width of 767px aprox, when the width is less than 767px the user are showee whit 4 columns and the design looks good. There aren't another change for less width. And a other change could be when you click the avatar of the user then you are redirected to the profile of this user, If this change is ok, I'll work it. #56-20/03/2014 14:54 - Yannick Warnier - Assignee changed from Daniel Barreto to Noa Orizales Iglesias Noa, could you review the current status on https://stable.chamilo.org and give us your opinion. We would like to close this task and, if incomplete, schedule the rest for Chamilo LMS 1.10 (but we need to make sure we are not loosing any of the suggestions made here). 21/12/2018 11/12
#57-20/03/2014 18:25 - Noa Orizales Iglesias - Status changed from Needs testing to Assigned - Assignee changed from Noa Orizales Iglesias to Yannick Warnier Works fine in firefox and Chrome. The buttons with the text are fine. You can close for now. #58-21/03/2014 00:48 - Yannick Warnier - Status changed from Assigned to Feature implemented - Assignee changed from Yannick Warnier to Yoselyn Castillo - % Done changed from 60 to 100 Files example.png 180 KB 07/03/2013 Noa Orizales Iglesias example.png 182 KB 12/03/2013 Alberto Montes svg_iconos.zip 132 KB 12/03/2013 Alberto Montes example2.png 128 KB 10/05/2013 Alberto Montes example3.png 127 KB 10/05/2013 Alberto Montes images.zip 4.08 KB 16/05/2013 Alberto Montes css_change.png 73.4 KB 20/05/2013 Alberto Montes social.gif 59.6 KB 20/05/2013 Yoselyn Castillo new-social.gif 65.7 KB 21/05/2013 Yoselyn Castillo Tooltip_004.png 24.1 KB 04/06/2013 Julio Montoya Selection_005.png 33.7 KB 04/06/2013 Julio Montoya Selection_001.png 32.4 KB 27/08/2013 Julio Montoya 21/12/2018 12/12