Subroutine to ILE Procedure

Transcription

1 Can you read? 1

2 Refactoring 2

3 GOTO Conversion 3

4 Subroutine to ILE Procedure 4

5 Modernization & Refactoring Improving the Design of Code, Database and More! 5

6 Refactoring 6

7 Today s Speaker 7

8 Refactoring 8

9 Business value of Refactoring? Eleni Stroulia 9

10 about Refactoring/Modernization previous refactoring events can you name them? general principles recognize code smell ugly code can stay recognize tradeoffs and obstacles to refactoring 10

11 11

12 12

13 What Happened? 13

14 Improve the Design of Existing Code 14

15 CISC to RISC 15

16 Four Digit Year 16

17 1956 5GB IBM Hard Drive 17

18 We is your code comfort? 18

19 Refactoring and DevOps Transition Lay the Foundation Analyze your existing resources Skillset, methodology, existing tooling Identify "Champions" Pick tools that match your needs and experience...not necessarily those that have the largest visibility Document Review Begin to install back office tooling Make incremental Development changes Start using RDi (if you aren't already) "Big Bang Refactoring or DevOps" not absolutely necessary Instead, consider making changes as part of already-defined (and already funded) projects 19

20 Development Transition - OO Start thinking in terms of "Objects" Matches what "Distributed" (Java, C#, C++) developers expect Often very similar to Database UML Related objects become service programs (*SRVPGM) Each object becomes a module (*MODULE) Actions becomes exported procedures Can be easily scripted for testing 20

21 Development Transition - MVC Separate Business Logic from User Interface (Model-View-Controller) Model Reference File View = 5250 (+Web, Mobile, Eclipse, Client Server,...) Controller = Module(s) (*MODULE) 21

22 Development Transition - TDD CI does not work without scriptable test cases... Test Driven Development (xunit overwhelmingly popular) JUnit: Customer cust = new Customer(); String[] location = {"665 Surf Terrace", "Wauconda", "IL"}; cust.setlocation(location); Order order = new Order(cust); boolean success = false; try { cust.delete(); } catch (Exception e) { assertthat(e, is(customerhasordersexception)); } assertthat(success, is(true)); RPGUnit: dcl-f orderf usage(*update:*delete); dcl-ds orderds likerec(orderrec); chain ('665 Surf Terrace' : 'Wauconda' : 'IL') orderrec orderds; assert (not %found : 'Record ("665 Surf Terrace", "Wauconda", "IL")' + 'should not be found'); 22

23 Legend Yes! Maybe No OMG No! 23

24 Development Transition - RPG Convert RPGIII to ILE No: GOTO; I-spec; O-spec; Cycle Free-form preferably More readable/quicker changes (especially for new developers) Easier tracking (fewer diff lines) Tooling: RDi H/S RPG Toolbox ARCAD RPG Converter for IBM i Convert subroutines to procedures (where appropriate) Minimal usage of global variables Review /COPY usage Fine for "macros" (e.g. sort) and copyright/version info Should never /COPY business logic into multiple programs 24

25 Development Transition Break up Large Programs Do multiple developers work on different parts of the same program? Multiple checkouts prevent feature promotion Resolving source conflicts (Sync) is the most difficult (and most costly) part of distributed development Are any of these true: Do you have >10 levels of indentation? Is your source increment.01?? Does the compiler sometimes crash when processing your source??? Have you already asked IBM to increase some limit so your program can compile?!?...answering yes, probably means your program isn't modular... 25

26 Rule of Three-Don Roberts Start thinking in terms of Three Strikes your Out" First time just do it-nike Always fit into workflow to refactor opportunistically Second time you do something similar, wince at duplication but do it anyway Third time you do something similar, you refactor 26

27 Rule of Three-Don Roberts Some techniques Third time you do something similar, you refactor Before you add a new feature, Preparatory Refactoring Making code easier to understand, Comprehensive Refactoring Litter-Pickup, understand but doing it badly Experiment, refactoring and new feature in separate commits (changes) Naming provides clarity and understanding, SQL table 27

28 Smelly Slide-Fixed to Free-Form RPG

29 GOTO Conversion

30 GOTO Conversion

31 GOTO Conversion 31

32 CALLx Conversion

33 MOVEA Conversion

34 PLIST Conversion

35 KLIST Conversion

36 Rule of One-Some Speaker(Me) Not limited to just code-database First time you do something, you refactor? Constraints-Database Centric Programming Performance Testing-Build Dependency-Concurrent Changes Surrogate-Religious War Naming provides clarity and understanding, SQL table 36

37 DDS to DDL conversion You can transform manually, buy a new application or Modernize/Refactor to drive additional Code transformation: - Field Renaming - Keyword management - Object renaming - Multi-member files management Copyright Arcad Software

38 Questions What did you think? 38