MET08-J. Preserve the equality contract when overriding the equals() method

Size: px

Start display at page:

Download "MET08-J. Preserve the equality contract when overriding the equals() method"

Anis Andrews
6 years ago
Views:

1 MET08-J. Preserve the equality contract when overriding the equals() method Composition or inheritance may be used to create a new class that both encapsulates an existing class and adds one or more fields. When one class extends another in this way, the concept of equality for the subclass may or may not involve its new fields. That is, when comparing two subclass objects for equality, sometimes their respective fields must also be equal, and other times they need not be equal. Depending on the concept of equality for the subclass, the subclass might override equals(). Furthermore, this method must follow the general contract for equal s(), as specified by The Java Language Specification (JLS) [ JLS 2015]. An object is characterized both by its identity (location in memory) and by its state (actual data). The == operator compares only the identities of two objects (to check whether the references refer to the same object); the equals() method defined in java.lang.object can be overridden to compare the state as well. When a class defines an equals() method, it implies that the method compares state. When the class lacks a customized equals() method (either locally declared or inherited from a parent class), it uses the default Object.equals() implementation inherited from Object. The default Object.equals() implementation compares only the references and may produce unexpected results. The equals() method applies only to objects, not to primitives. Enumerated types have a fixed set of distinct values that may be compared using == rather than the equals() method. Note that enumerated types provide an equals() implementation that uses == internally; this default cannot be overridden. More generally, subclasses that both inherit an implementation of equals() from a superclass and lack a requirement for additional functionality need not override the equals() method. The general usage contract for equals(), as specified by the JLS, establishes five requirements: 1. It is reflexive: For any reference value x, x.equals(x) must return true. 2. It is symmetric: For any reference values x and y, x.equals(y) must return true if and only if y.equals(x) returns true. 3. It is transitive: For any reference values x, y, and z, if x.equals(y) returns true and y.equals(z) returns true, then x.equals(z) m ust return true. 4. It is consistent: For any reference values x and y, multiple invocations of x.equals(y) consistently return true or consistently return false, provided no information used in equals() comparisons on the object is modified. 5. For any non-null reference value x, x.equals(null) must return false. Never violate any of these requirements when overriding the equals() method. Noncompliant Code Example (Symmetry) This noncompliant code example defines a CaseInsensitiveString class that includes a String and overrides the equals() method. The CaseInsensitiveString class knows about ordinary strings, but the String class has no knowledge of case-insensitive strings. Consequently, the CaseInsensitiveString.equals() method should not attempt to interoperate with objects of the String class.

2 public final class CaseInsensitiveString { private String s; public CaseInsensitiveString(String s) { if (s == null) { throw new NullPointerException(); this.s = s; // This method violates symmetry if (o instanceof CaseInsensitiveString) { return s.equalsignorecase(((caseinsensitivestring)o).s); if (o instanceof String) { return s.equalsignorecase((string)o); // Comply with MET09-J public int hashcode() {/*... */ public static void main(string[] args) { CaseInsensitiveString cis = new CaseInsensitiveString("Java"); String s = "java"; System.out.println(cis.equals(s)); // Returns true System.out.println(s.equals(cis)); // Returns false By operating on String objects, the CaseInsensitiveString.equals() method violates the second contract requirement (symmetry). Because of the asymmetry, given a String object s and a CaseInsensitiveString object cis that differ only in case, cis.equals(s)) ret urns true, while s.equals(cis) returns false. Compliant Solution In this compliant solution, the CaseInsensitiveString.equals() method is simplified to operate only on instances of the CaseInsensitiv estring class, consequently preserving symmetry:

3 public final class CaseInsensitiveString { private String s; public CaseInsensitiveString(String s) { if (s == null) { throw new NullPointerException(); this.s = s; return o instanceof CaseInsensitiveString && ((CaseInsensitiveString)o).s.equalsIgnoreCase(s); public int hashcode() {/*... */ public static void main(string[] args) { CaseInsensitiveString cis = new CaseInsensitiveString("Java"); String s = "java"; System.out.println(cis.equals(s)); // Returns false now System.out.println(s.equals(cis)); // Returns false now Noncompliant Code Example (Transitivity) This noncompliant code example defines an XCard class that extends the Card class. public class Card { private final int number; public Card(int number) { this.number = number; if (!(o instanceof Card)) { Card c = (Card)o; return c.number == number; public int hashcode() {/*... */

4 class XCard extends Card { private String type; public XCard(int number, String type) { super(number); this.type = type; if (!(o instanceof Card)) { // Normal Card, do not compare type if (!(o instanceof XCard)) { return o.equals(this); // It is an XCard, compare type as well XCard xc = (XCard)o; return super.equals(o) && xc.type == type; public int hashcode() {/*... */ public static void main(string[] args) { XCard p1 = new XCard(1, "type1"); Card p2 = new Card(1); XCard p3 = new XCard(1, "type2"); System.out.println(p1.equals(p2)); // Returns true System.out.println(p2.equals(p3)); // Returns true System.out.println(p1.equals(p3)); // Returns false // violating transitivity

5 In the noncompliant code example, p1 and p2 compare equal and p2 and p3 compare equal, but p1 and p3 compare unequal, violating the transitivity requirement. The problem is that the Card class has no knowledge of the XCard class and consequently cannot determine that p2 and p3 have different values for the field type. Compliant Solution (Delegation) Unfortunately, in this case it is impossible to extend the Card class by adding a value or field in the subclass while preserving the equals() cont ract. This problem is not specific to the Card class but applies to any class hierarchy that can consider equal instances of distinct subclasses of some superclass. For such cases, use composition rather than inheritance to achieve the desired effect [ Bloch 2008]. This compliant solution adopts this approach by adding a private card field to the XCard class and providing a public viewcard() method. class XCard { private String type; private Card card; // Composition public XCard(int number, String type) { card = new Card(number); this.type = type; public Card viewcard() { return card; if (!(o instanceof XCard)) { XCard cp = (XCard)o; return cp.card.equals(card) && cp.type.equals(type); public int hashcode() {/*... */ public static void main(string[] args) { XCard p1 = new XCard(1, "type1"); Card p2 = new Card(1); XCard p3 = new XCard(1, "type2"); XCard p4 = new XCard(1, "type1"); System.out.println(p1.equals(p2)); // Prints false System.out.println(p2.equals(p3)); // Prints false System.out.println(p1.equals(p3)); // Prints false System.out.println(p1.equals(p4)); // Prints true

6 Compliant Solution (Class Comparison) If the Card.equals() method could unilaterally assume that two objects with distinct classes were not equal, it could be used in an inheritance hierarchy while preserving transitivity: public class Card { private final int number; public Card(int number) { this.number = number; if (!(o.getclass() == this.getclass())) { Card c = (Card)o; return c.number == number; public int hashcode() {/*... */ Noncompliant Code Example (Consistency) A uniform resource locator (URL) specifies both the location of a resource and a method to access it. According to the Java API documentation for Class URL [ API 2014]: Two URL objects are equal if they have the same protocol, reference equivalent hosts, have the same port number on the host, and the same file and fragment of the file. Two hosts are considered equivalent if both host names can be resolved into the same IP addresses; else if either host name can't be resolved, the host names must be equal without regard to case; or both host names equal to null. The defined behavior for the equals() method is known to be inconsistent with virtual hosting in HTTP. Virtual hosting allows a web server to host multiple websites on the same computer, sometimes sharing the same IP address. Unfortunately, this technique was unanticipated when the URL class was designed. Consequently, when two completely different URLs resolve to the same IP address, the URL class considers them to be equal. Another risk associated with the equals() method for URL objects is that the logic it uses when connected to the Internet differs from that used when disconnected. When connected to the Internet, the equals() method follows the steps described in the Java API; when disconnected, it performs a string compare on the two URLs. Consequently, the URL.equals() method violates the consistency requirement for equals(). Consider an application that allows an organization's employees to access an external mail service via The application is designed to deny access to other websites by behaving as a makeshift firewall. However, a crafty or malicious user could nevertheless access an illegitimate website if it were hosted on the same computer as the legitimate website and consequently shared the same IP address. Even worse, if the legitimate website were hosted on a server in a commercial pool of servers, an attacker could register multiple websites in the pool (for phishing purposes) until one was registered on the same computer as the legitimate website, consequently defeating the firewall.

7 public class Filter { public static void main(string[] args) throws MalformedURLException { final URL allowed = new URL(" if (!allowed.equals(new URL(args[0]))) { throw new SecurityException("Access Denied"); // Else proceed Compliant Solution (Strings) This compliant solution compares the string representations of two URLs, thereby avoiding the pitfalls of URL.equals() : public class Filter { public static void main(string[] args) throws MalformedURLException { final URL allowed = new URL(" if (!allowed.tostring().equals(new URL(args[0]).toString())) { throw new SecurityException("Access Denied"); // Else proceed This solution still has problems. Two URLs with different string representation can still refer to the same resource. However, the solution fails safely in this case because the equals() contract is preserved, and the system will never allow a malicious URL to be accepted by mistake. Compliant Solution ( URI.equals() ) A Uniform Resource Identifier (URI) contains a string of characters used to identify a resource; this is a more general concept than an URL. The j ava.net.uri class provides string-based equals() and hashcode() methods that satisfy the general contracts for Object.equals() and Object.hashCode() ; they do not invoke hostname resolution and are unaffected by network connectivity. URI also provides methods for normalization and canonicalization that URL lacks. Finally, the URL.toURI() and URI.toURL() methods provide easy conversion between the two classes. Programs should use URIs instead of URLs whenever possible. According to the Java API Class URI documentation [ API 2014]: A URI may be either absolute or relative. A URI string is parsed according to the generic syntax without regard to the scheme, if any, that it specifies. No lookup of the host, if any, is performed, and no scheme-dependent stream handler is constructed. This compliant solution uses a URI object instead of a URL. The filter appropriately blocks the website when presented with any string other than because the comparison fails.

8 public class Filter { public static void main(string[] args) throws MalformedURLException, URISyntaxException { final URI allowed = new URI(" if (!allowed.equals(new URI(args[0]))) { throw new SecurityException("Access Denied"); // Else proceed Additionally, the URI class performs normalization (removing extraneous path segments such as "..") and relativization of paths [ API 2014], [ Dar win 2004]. Noncompliant Code Example ( java.security.key) The method java.lang.object.equals() by default is unable to compare composite objects such as cryptographic keys. Most Key classes lack an equals() implementation that would override Object's default implementation. In such cases, the components of the composite object must be compared individually to ensure correctness. This noncompliant code example compares two keys using the equals() method. The comparison may return false even when the key instances represent the same logical key. private static boolean keysequal(key key1, Key key2) { if (key1.equals(key2)) { return true; Compliant Solution ( java.security.key) This compliant solution uses the equals() method as a first test and then compares the encoded version of the keys to facilitate provider-independent behavior. For example, this code can determine whether a RSAPrivateKey and RSAPrivateCrtKey represent equivalent private keys [ Sun 2006].

9 private static boolean keysequal(key key1, Key key2) { if (key1.equals(key2)) { return true; if (Arrays.equals(key1.getEncoded(), key2.getencoded())) { return true; // More code for different types of keys here. // For example, the following code can check if // an RSAPrivateKey and an RSAPrivateCrtKey are equal: if ((key1 instanceof RSAPrivateKey) && (key2 instanceof RSAPrivateKey)) { if ((((RSAKey)key1).getModulus().equals( ((RSAKey)key2).getModulus())) && (((RSAPrivateKey) key1).getprivateexponent().equals( ((RSAPrivateKey) key2).getprivateexponent()))) { return true; Exceptions MET08-J-EX0: Requirements of this rule may be violated provided that the incompatible types are never compared. There are classes in the Java platform libraries (and elsewhere) that extend an instantiable class by adding a value component. For example, java.sql.timestamp extends java.util.date and adds a nanoseconds field. The equals() implementation for Timestamp violates symmetry and can cause erratic behavior when Timestamp and Date objects are used in the same collection or are otherwise intermixed [ Bloch 2008]. Risk Assessment Violating the general contract when overriding the equals() method can lead to unexpected results. Rule Severity Likelihood Remediation Cost Priority Level MET08-J Low Unlikely Medium P2 L3 Automated Detection Tool Version Checker Description CodeSonar 4.5p1 FB.BAD_PRACTICE.EQ_GETCLASS_AND_CLASS_CONSTANT FB.CORRECTNESS.OVERRIDING_EQUALS_NOT_SYMMETRIC equals method fails for subtypes equals method overrides equals in superclass and may not be symmetric SonarQube Java Plugin 4.11 S2162

10 Related Guidelines MITRE CWE CWE-697, Insufficient Comparison Bibliography [ API 2014] Class URI Class URL (method equals() ) [ Bloch 2008] Item 8, "Obey the General Contract When Overriding equals" [ Darwin 2004] Section 9.2, "Overriding the equals Method" [ Harold 1997] [ Sun 2006] [ Techtalk 2007 ] Chapter 3, "Classes, Strings, and Arrays," section "The Object Class (Equality)" Determining If Two Keys Are Equal (JCA Reference Guide) "More Joy of Sets"

The class Object. Lecture CS1122 Summer 2008

The class Object. Lecture CS1122 Summer 2008 The class Object http://www.javaworld.com/javaworld/jw-01-1999/jw-01-object.html Lecture 10 -- CS1122 Summer 2008 Review Object is at the top of every hierarchy. Every class in Java has an IS-A relationship