James Cowie Software Engineer Session

Transcription

1

2 James Cowie Software Engineer Session

3 Getting ready for Magento 2 How to prepare for a new e- commerce system

4 Whats changed since Magento 1?

5 PHP has changed

6 PHP since Magento 1 Composer Namespaces - PHP Traits - PHP Generators - PHP Better Interface support PHP Type Hinting - PHP

7 The world of engineering has changed

8 Software Engineering Server Architecture Cloud Docker VPS Software Architecture within PHP TDD PHPSpec BDD Behat DDD

9 Installing Magento

10 How did we install Magento 1 Large scale bundled installations per versions.

11 Along came composer

12 Installing Magento 2 with composer composer create-project --stability=beta --no-install magento/project-community-edition M2Test

13 { } Whats this created "name": "magento/project-community-edition", "type": "project", "require": { "magento/product-community-edition": " beta12" }, "require-dev": { }

14 But wait there is more composer offers

15 More Composer Packagist + packages.magento.com Package versioning Dependency Management

16 Show me the use case! composer require "league/period"

17 1 /** 2 League\Period\Period; 3 */ 4 protected $_dateperiod; 5 6 /** 7 \League\Period\Period; $dateperiod 8 */ 9 public function construct(\league\period\period $dateperiod) 10 { 11 $this->_dateperiod = $dateperiod; 12 }

18 Composer 101 Versioning In Composer

19 Composer 101 Exact version: 1.4.2, v "magento/product-community-edition": 1.0.1

20 Composer 101 Ranges: >=1.0, <2.0, "magento/product-community-edition": >=1.0, <2

21 Composer 101 Wildcard: 1.0.*, 1.* "magento/product-community-edition": 1.* "magento/product-community-edition": 1.0.*

22 Composer 101 Next Significant Release: ~1.2 is equivalent to >=1.2,<2.0. "magento/product-community-edition": ~1.2

23 A note on semver

24 Decoupling modules

25 Better Module Architecture

26 We can and should apply best software practice to Magento

27 Benefits of decoupling modules? Clean Code Reusable packages Testable Easier to read Easier to maintain

28 Yea but in Magento 1 we could not fully do this..

29 Decoupling in Magento 1 No Dependency Injection container. Mage god class Hard to test Hard to decouple logic

30 Dependency Injection in Magento 2

31

32 public function construct( \Magento\Framework\App\Action\Context $context, \Magento\Catalog\Model\Design $catalogdesign, \Magento\Catalog\Model\Session $catalogsession, \Magento\Framework\Registry $coreregistry, \Magento\Store\Model\StoreManagerInterface $storemanager, \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator $categoryurlpathgenerator PageFactory $resultpagefactory, \Magento\Framework\Controller\Result\ForwardFactory $resultforwardfactory, Resolver $layerresolver, CategoryRepositoryInterface $categoryrepository \Magento\Framework\App\Action\Context $context, \Magento\Catalog\Model\Design $catalogdesign, \Magento\Catalog\Model\Session $catalogsession, \Magento\Framework\Registry $coreregistry, \Magento\Store\Model\StoreManagerInterface $storemanager, \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator

33 public function construct( \Magento\Framework\App\Action\Context $context, \Magento\Catalog\Model\Design $catalogdesign, \Magento\Catalog\Model\Session $catalogsession, \Magento\Framework\Registry $coreregistry, \Magento\Store\Model\StoreManagerInterface $storemanager, \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator $categoryurlpathgenerator, PageFactory Code $resultpagefactory, Smell \Magento\Framework\Controller\Result\ForwardFactory $resultforwardfactory, Resolver $layerresolver, CategoryRepositoryInterface $categoryrepository \Magento\Framework\App\Action\Context $context, \Magento\Catalog\Model\Design $catalogdesign, \Magento\Catalog\Model\Session $catalogsession, \Magento\Framework\Registry $coreregistry, \Magento\Store\Model\StoreManagerInterface $storemanager, \Magento\CatalogUrlRewrite\Model\CategoryUrlPathGenerator

34 Information on DI Dependency Injection replaces Mage:: god class Dependency Injection can be overused. Dependency Injection enables composition.

35 How we manage dependencies without Injection 1 <?php 2 class Sample 3 { 4 protected $logger; 5 6 public function dosomething() 7 { 8 $this->logger = new \Logger(); 9 $logger->dosomething(); 10 } 11 }

36 How we manage dependencies without Injection 1 <?php 2 class Sample 3 { 4 protected $logger; 5 6 public function dosomething() 7 { 8 $this->logger = new \Logger(); 9 $logger->dosomething(); 10 } 11 }

37 Basic Dependency Injection 1 <?php 2 class SampleDi { 3 protected $logger; 4 public function construct(\logger $logger) { 5 $this->logger = $logger; 6 } 7 8 public function dosomething() { 9 $this->logger->dosomething(); 10 } 11 }

38 Basic Dependency Injection 1 <?php 2 class SampleDi { 3 protected $logger; 4 public function construct(\logger $logger) { 5 $this->logger = $logger; 6 } 7 8 public function dosomething() { 9 $this->logger->dosomething(); 10 } 11 }

39 Basic Dependency Injection 1 <?php 2 class SampleDi { 3 protected $logger; 4 public function construct(\logger $logger) { 5 $this->logger = $logger; 6 } 7 8 public function dosomething() { 9 $this->logger->dosomething(); 10 } 11 }

40 What are the benefits of DI? Creating a new instance of logger is removed from the class. Concrete implementation of Logger can be swapped out via container configuration When running tests we can Mock the dependency

41 How does this look within Magento 2

42 /** \Magento\Framework\View\Element\Context $context */ public function construct( \Magento\Framework\View\Element\Context $context ) { parent:: construct($context, $data); }

43 DI Continued Its not only Objects that can be injected.

44 <type name="magento\cms\model\wysiwyg\images\storage"> <arguments> <argument name="extensions" xsi:type="array"> <item name="allowed" xsi:type="array"> <item name="jpg" xsi:type="number">1</item> <item name="jpeg" xsi:type="number">1</item> <item name="png" xsi:type="number">1</item> <item name="gif" xsi:type="number">1</item> </item> </argument> </arguments>

45 <type name="magento\cms\model\wysiwyg\images\storage"> <arguments> <argument name="extensions" xsi:type="array"> <item name="allowed" xsi:type="array"> <item name="jpg" xsi:type="number">1</item> <item name="jpeg" xsi:type="number">1</item> <item name="png" xsi:type="number">1</item> <item name="gif" xsi:type="number">1</item> </item> </argument> </arguments>

46 <type name="magento\cms\model\wysiwyg\images\storage"> <arguments> <argument name="extensions" xsi:type="array"> <item name="allowed" xsi:type="array"> <item name="jpg" xsi:type="number">1</item> <item name="jpeg" xsi:type="number">1</item> <item name="png" xsi:type="number">1</item> <item name="gif" xsi:type="number">1</item> </item> </argument> </arguments>

47 <type name="magento\cms\model\wysiwyg\images\storage"> <arguments> <argument name="extensions" xsi:type="array"> <item name="allowed" xsi:type="array"> <item name="jpg" xsi:type="number">1</item> <item name="jpeg" xsi:type="number">1</item> <item name="png" xsi:type="number">1</item> <item name="gif" xsi:type="number">1</item> </item> </argument> </arguments>

48 protected $_extensions; public function construct( array $extensions = [] ) { $this->_extensions = $extensions; }

49 $allowed = $this->_extensions["{$type}_allowed"];

50 Inversion of Control Separating instantiation of objects from the object Easier to test Aids with Separation of concerns

51 How can we test this?

52

53

54 function it_should_create_a_new_cached_image($filesystem) { $filesystem->beadoubleof( \Magento\Framework\Filesystem $filesystem); } $this->createcachedfile($filesystem) ->shouldreturntrue();

55 Closing thoughts

56 Composer can help create reusable packages Dependency Injection is a must, Yet be careful on how many dependencies are injected Testing has become easier Decoupling of modules is now easier Magento 2 service contracts / Design by contract ( Interfaces )

57 Thank-you and any questions?