Chamilo LMS - Bug #6044 AICC import - "The package you are trying to upload has an unknown format."

Transcription

1 Chamilo LMS - Bug #6044 AICC import - "The package you are trying to upload has an unknown format." 19/03/ :13 - Terence van Jaarsveldt Status: Bug resolved Start date: 19/03/2013 Priority: Normal Due date: Assignee: Yannick Warnier % Done: 100% Category: Learning paths / Lecciones Estimated time: 0.00 hour Target version: Spent time: 0.00 hour Complexity: Normal SCRUM pts - complexity:? Description Hi I have a problem when importing an AICC package in chamilo. My installation is a normal clean chamilo installation. I tried this on multiple servers including localhost. I also tried with installation with same results. When I try to upload the AICC package (.zip - 6KB) it shows this error: The package you are trying to upload has an unknown format. Please check it uses one of the supported formats. This is a test AICC package that has been tested on other portals. Thank you Associated revisions Revision abf5cf78-02/12/ :56 - Yannick Warnier Fix bug with unrecognized AICC format - refs #6044 History #1-04/04/ :16 - Terence van Jaarsveldt Anyone please help. This is really urgent! #2-04/04/ :58 - Yannick Warnier - Priority changed from Urgent to Normal Hi Terence, Sorry, we are apparently all very busy at the moment. We generally prioritize support to people who have provided support to others previously in our big family. Seeing this is your first contribution here, don't get your hopes too high. We will help eventually, but we all have very urgent stuff to do. You can find the code related to this error around line 26 of main/upload/upload.scorm.php (as you have installed Chamilo which isn't considered stable yet, I assume you have technical skills of some kind). The AICC support has been left uncared for several years now, so you might need to refresh some little things to get it working. Let us know if you fix it (that will count for the next time you need help). 22/09/2018 1/6

2 Please, do not use the "Priority" setting of the task if you are not yourself an active contributor. This is to indicate that this task is urgent for the community at large. Thank you for reporting. #3-04/04/ :08 - Terence van Jaarsveldt Thank you very much. I will work on this and return on this topic. Sorry for using the priority setting. Maybe let people know of this in the reporting guide or maybe I missed it. #4-12/08/ :05 - Terence van Jaarsveldt Hello everyone I am at a total loss. I can't seem to get anything to work. Could anyone please help with this or direct me in the right direction please. #5-20/08/ :04 - Terence van Jaarsveldt Hello I tried to upload a test AICC package and a sample AICC package that I found on both the Chamilo LMS and Chamilo LCMS demo/try sites. This failed with the same error. Both of these courses uploaded successfully on Scormcloud as well. Please help #6-20/08/ :29 - Marko Kastelic hi, some days ago i construct course 'AICC test' (or something) on stable chamilo. I uploaded some sample aicc packages (document repository). I notices that uploading of the package fails when manifest file is not included in the package (manifest????). Than; with the sample from CourseLab (2) with included manifest; there are some problems in interaction with api (no progress stored,...). I did not found the time to investigate further... #7-21/08/ :28 - Yannick Warnier Hi Terence, do you have a test package we can try out? #8-21/08/ :37 - Marko Kastelic Looks like AICC package cannot be recognized. The piece of code from main/newscorm/learnpath.class.php (get_package_type/2), from line 1856: elseif (preg_match('/aicc\//i', $thiscontent['filename'])) { // If found an aicc directory... (!= false means it cannot be false (error) or 0 (no match)). $package_type = 'aicc'; // // Don't exit the loop, because if we find an imsmanifest afterwards, we want it, not the AICC. 22/09/2018 2/6

3 looks for aicc folder and fails if there is no one. From aicc package specification: package contains files with extensions: - CRS - Course Description file (mandatory) - AU - Assignable Unit file (mandatory) - DES - Descriptor file (mandatory) - CST - Course Structure file (mandatory) - ORE - Objective Relationship file (optional) - PRE - Prerequisites file (optional) - CMP - Completion Requirements file (optional) so we should check if there is one of the mandatory files in the root of the package, like: elseif (preg_match('/aicc\//i', $thiscontent['filename'])!= false in_array(strtolower(pathinfo($thiscontent['filename'], PATHINFO_EXTENSION)), array( 'crs','au','des','cst'))) { this one fails if there is a file with different extension than one specified with array or elseif (preg_match('/aicc\//i', $thiscontent['filename'])!=false strtolower(pathinfo($thiscontent['filename'], PATHINFO_EXTENSION)) == 'crs') { with a little change in the rest of code (does we really need else { at the end of the method? as for manifest: there shouldn't be one as package is recognized as scorm #9-21/08/ :40 - Yannick Warnier I think it's worth putting a little bit more of the context here... this is the uncut part of the original code in Chamilo 1.9.6: $zipfile = new PclZip($file_path); // Check the zip content (real size and file extension). $zipcontentarray = $zipfile->listcontent(); $at_root = false; $manifest = ''; // The following loop should be stopped as soon as we found the right imsmanifest.xml (how to recognize it?). if (is_array($zipcontentarray) && count($zipcontentarray) > 0) { foreach ($zipcontentarray as $thiscontent) { if (preg_match('~.(php.* phtml)$~i', $thiscontent['filename'])) { // New behaviour: Don't do anything. These files will be removed in scorm::import_package. 22/09/2018 3/6

4 elseif (stristr($thiscontent['filename'], 'imsmanifest.xml')!== false) { $manifest = $thiscontent['filename']; // Just the relative directory inside scorm/ $package_type = 'scorm'; // Exit the foreach loop. elseif (preg_match('/aicc\//i', $thiscontent['filename'])) { // If found an aicc directory... (!= false means it cannot be false (error) or 0 (no match)). $package_type = 'aicc'; // // Don't exit the loop, because if we find an imsmanifest afterwards, we want it, not the AICC. else { return $package_type; From the requirements you indicate (Marko), it is important that all 4 of these files be present. The resulting code should thus be something like this: $zipfile = new PclZip($file_path); // Check the zip content (real size and file extension). $zipcontentarray = $zipfile->listcontent(); $at_root = false; $manifest = ''; $aicc_match_crs = 0; $aicc_match_au = 0; $aicc_match_des = 0; $aicc_match_cst = 0; // The following loop should be stopped as soon as we found the right imsmanifest.xml (how to recognize it?). if (is_array($zipcontentarray) && count($zipcontentarray) > 0) { foreach ($zipcontentarray as $thiscontent) { if (preg_match('~.(php.* phtml)$~i', $thiscontent['filename'])) { // New behaviour: Don't do anything. These files will be removed in scorm::import_package. elseif (stristr($thiscontent['filename'], 'imsmanifest.xml')!== false) { $manifest = $thiscontent['filename']; // Just the relative directory inside scorm/ $package_type = 'scorm'; // Exit the foreach loop. elseif (preg_match('/aicc\//i', $thiscontent['filename']) in_array(strtolower(pathinfo($thiscontent['filename'], PATHINFO_EXTENSION)), array( 'crs','au','des','cst'))) { $ext = strtolower(pathinfo($thiscontent['filename'], PATHINFO_EXTENSION)); switch ($ext) { case 'crs': $aicc_match_crs = 1; case 'au': $aicc_match_au = 1; 22/09/2018 4/6

5 case 'des': $aicc_match_des = 1; case 'cst': $aicc_match_cst = 1; default: // // Don't exit the loop, because if we find an imsmanifest afterwards, we want it, not the AICC. else { if (empty($package_type) && 4 == ($aicc_match_crs + $aicc_match_au + $aicc_match_des + $aicc_match_cst)) { // If found an aicc directory... (!= false means it cannot be false (error) or 0 (no match)). $package_type = 'aicc'; return $package_type; I think that would do it in a better way (at least taking into account the 4 "mandatory" items you mentionned). Terence, are you OK with trying out this test code, or do you need a specially-crafted zip? I'm asking because it makes us work more to provide betas to anyone, but that really helps if the opposite is not requesting but not helping at all either. #10-21/08/ :12 - Marko Kastelic test aicc packages : will be nice to get one from Terence... (my courselab sample sets score but not progress) edit: upload works like charm. Testted and can be implemented. #11-21/08/ :45 - Terence van Jaarsveldt - File L_ zip added - File sample_crs_flash.zip added Thank you for pursuing this. I'm attaching the test course and the sample course that I referred to previously. #12-23/08/ :22 - Yannick Warnier - Category set to Learning paths / Lecciones - Target version set to #13-02/09/ :51 - Terence van Jaarsveldt 22/09/2018 5/6

6 Hello everyone Is there maybe an update on this? #14-19/09/ :25 - Terence van Jaarsveldt Any news on this matter? I really would like to start using AICC. #15-30/09/ :01 - Terence van Jaarsveldt Hello? If there is any other resources that I need to provide, please let me know. #16-30/09/ :06 - Marko Kastelic - File learnpath.class.php added replace the original file.../main/newscorm/learnpath.class.php with attached one. note: package will load, but your samples(because of crossdomain content) probably won't. #17-22/10/ :20 - Yoselyn Castillo - Status changed from New to Assigned - Assignee set to Yoselyn Castillo checking.. #18-24/10/ :48 - Yoselyn Castillo - Status changed from Assigned to New - Assignee deleted (Yoselyn Castillo) #19-02/12/ :57 - Yannick Warnier - Status changed from New to Bug resolved - Assignee set to Yannick Warnier - % Done changed from 0 to 100 Terrence, I will be closing this task for lack of feedback. I have applied the changes documented previously (and sent as file by Marko), so as far as I am concerned, Marko having confirmed and all, this issue is fixed. Files Untitled.png 21.7 KB 19/03/2013 Terence van Jaarsveldt L_ zip 1.62 KB 21/08/2013 Terence van Jaarsveldt sample_crs_flash.zip 1 KB 21/08/2013 Terence van Jaarsveldt learnpath.class.php 426 KB 30/09/2013 Marko Kastelic 22/09/2018 6/6

7